Fixes an issue where asking a mock for values in a concurrent way causes a crash in the VerifyContainer #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses a crash in the VerifyContainer
NineToeNerd
approved these changes
Nov 22, 2024
NineToeNerd
suggested changes
Dec 5, 2024
MetalheadSanya
requested changes
Jan 8, 2025
| isVerified.append(false) | ||
|
|
||
| InOrderContainer.append(mock: mock, call: call, function: function) | ||
| queue.sync { [weak self] in |
There was a problem hiding this comment.
Kinda wierd. We call closure synchronous on the queue, but capture self in a weak manner.
Just use unowned reference
| @@ -11,15 +11,18 @@ public class VerifyContainer: CallContainer { | |||
| var calls: [Any] = [] | |||
| var functions: [String] = [] | |||
| var isVerified: [Bool] = [] | |||
|
|
|||
| private let queue = DispatchQueue(label: "VerifyContainerQueue") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we try to access a mocked value when another thread is accessing the mock at the same time, we can get a crash.
We're seeing this consistently when we're running Xcode tests repeatedly.
We're now appending to the arrays in
VerifyContainerandInOrderContainerin a thread-safe manner.